Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grid pattern appear #112

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Make grid pattern appear #112

merged 2 commits into from
Jun 2, 2022

Conversation

alflennik
Copy link
Contributor

Address issue #102.

@netlify
Copy link

netlify bot commented Jun 1, 2022

Deploy Preview for wai-aria-practices2 ready!

Name Link
🔨 Latest commit 6587cf5
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria-practices2/deploys/6298f4a079718000089ec401
😎 Deploy Preview https://deploy-preview-112--wai-aria-practices2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@richnoah
Copy link

richnoah commented Jun 1, 2022

@alflennik I see Grid present and the content looks good.

@alflennik alflennik requested a review from howard-e June 1, 2022 22:16
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alflennik looks good to me other than the comment relating to the alphabetical order on the patterns page. Good stuff!

Another thing of note is on Data Grid Examples Page, Example 2: Sortable Data Grid With Editable Cells. There appears to be some conflicting CSS here which is forcing the edit icon over the column line for its respective cell. But that's outside the purpose of this PR and I believe there may be an over-arching task to account for these kind of tasks? If not, it could be filed in a separate issue.

content/patterns.md Outdated Show resolved Hide resolved
@alflennik
Copy link
Contributor Author

@howard-e I decided to go ahead and fix the offending example.

Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alflennik looks good and thanks for taking the time to address the non-blocking CSS issue as well!

@alflennik alflennik merged commit 119df14 into main Jun 2, 2022
@mcking65
Copy link
Contributor

mcking65 commented Jun 3, 2022

Thank you @alflennik!!!

@remibetin remibetin deleted the grid branch November 19, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants